Automating the sift react native releases.#30
Conversation
There was a problem hiding this comment.
It looks like you haven't ran this workflow with the release step. If you don't want to publish an actual release, there are ways to use release-it to run a pre-release, draft, etc.
https://github.com/release-it/release-it/blob/HEAD/docs/configuration.md#configuration
https://github.com/release-it/release-it/blob/HEAD/config/release-it.json#L39C11-L39C11
| - name: Run tests | ||
| run: npm test | ||
|
|
||
| # Release arent available, uncomment below lines when release is available |
There was a problem hiding this comment.
Is there a reason why the step to perform the release is commented out? Sounds like the release should actually run as part of this workflow?
| # - name: Release the package | ||
| # run: | | ||
| # npm run release -- --yes | ||
| # git push --follow-tags |
There was a problem hiding this comment.
Why do we run git push? I don't see that step in the release runbook
| # Release arent available, uncomment below lines when release is available | ||
| # - name: Release the package | ||
| # run: | | ||
| # npm run release -- --yes |
There was a problem hiding this comment.
Based on the runbook, it looks like the npm run release command will ask for a TOTP to authenticate for NPM. Does this --yes flag work around that?
Purpose:
Testing: